chore(docs): update subquery documentation with more information#10361
Merged
alamb merged 6 commits intoapache:mainfrom May 7, 2024
Merged
chore(docs): update subquery documentation with more information#10361alamb merged 6 commits intoapache:mainfrom
alamb merged 6 commits intoapache:mainfrom
Conversation
alamb
reviewed
May 3, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @sanderson -- this looks really nice 😍
I think there are a few minor changes that could make this more accurate but overall this is looking 🌶️ 👌
Very nice
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
github-actions
bot
removed
the
documentation
alamb
approved these changes
May 7, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Awesome - thank you so much @sanderson 🙏
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…che#10361) * chore(docs): update subquery documentation with more details and examples * chore(docs): ran prettier on content updates * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * chore(docs): address PR feedback for subqueries * chore(docs): updated subquery doc formatting and style --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This doesn't close an issue, but adds more detailed subquery documentation.
Part of #7013
Rationale for this change
Provides more information about how to use subqueries and what types of subqueries can be used.
What changes are included in this PR?
It just updates the subquery documentation.
Are these changes tested?
All examples in the proposed changes have been tested.
Are there any user-facing changes?
Nothing in the product itself. Just documentation.