Skip to content

Add cast array test to sqllogictest#10474

Merged
jonahgao merged 1 commit intoapache:mainfrom
viirya:add_cast_test
May 13, 2024
Merged

Add cast array test to sqllogictest#10474
jonahgao merged 1 commit intoapache:mainfrom
viirya:add_cast_test

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented May 12, 2024

Which issue does this PR close?

Closes #10464.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label May 12, 2024
Copy link
Copy Markdown
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alamb
Copy link
Copy Markdown
Contributor

alamb commented May 13, 2024

@jonahgao perhaps you would like to try merging this PR as a test that we have all the permissions setup correctly ?

@jonahgao
Copy link
Copy Markdown
Member

@jonahgao perhaps you would like to try merging this PR as a test that we have all the permissions setup correctly ?

Sure.

@jonahgao jonahgao merged commit 5fac581 into apache:main May 13, 2024
@jonahgao
Copy link
Copy Markdown
Member

Thanks @viirya and thank you @alamb for letting me experience this.

@viirya
Copy link
Copy Markdown
Member Author

viirya commented May 13, 2024

Thank you @alamb @jonahgao

@viirya viirya deleted the add_cast_test branch May 13, 2024 14:23
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: CAST(<array>) causes internal error

3 participants