fix: parsing timestamp with date format#10476
Merged
alamb merged 2 commits intoapache:mainfrom May 15, 2024
Merged
Conversation
Contributor
|
Thank you for the contribution @shanretoo . I started the CI runs for this PR cc @Omega359 |
Contributor
|
Thanks for the contribution! It would be a nice addition to add the format test to dates.slt |
Contributor
Author
alamb
approved these changes
May 14, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you very much @shanretoo and @Omega359
Contributor
Author
|
It seems I don't have write access to this repo. |
Contributor
That is right @shanretoo -- yes only committers can do so (see this page) I normally try to leave approved PRs open for a while to give anyone else who may want a chance to comment Thanks again for the contribution 🚀 |
Contributor
|
I made #10532 to try and clarify the PR flow |
Contributor
Author
|
Thank you for your explanation! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* fix parsing timestamp with date format * add test in dates.slt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10471.
Rationale for this change
Fallback to
Parsed::to_naive_datewhenParsed::to_naive_datetime_with_offsetfailed if there is only date in format string.What changes are included in this PR?
Same as above.
Are these changes tested?
The timestamp of "2022-01-23" is
1642896000000000000as written in the test.Are there any user-facing changes?
No