[MINOR]: Move pipeline checker rule to the end#10502
Merged
alamb merged 2 commits intoapache:mainfrom May 15, 2024
Merged
Conversation
mustafasrepo
changed the title
alamb
approved these changes
May 14, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @mustafasrepo
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Move pipeline checker to last * Update slt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
PipelineCheckerrule either accepts the physical plan (marking it as safe to execute) or rejects it. In this sense, it doesn't change anything in the plan. It just checks the validity of the generated plan. Hence, I think with this behavior it is more apropriate for this rule to execute after other rules (where plans might be modified by rules.)With this PR,
PipelineCheckerworks at the end after other rules.What changes are included in this PR?
Are these changes tested?
Existing tests, should work
Are there any user-facing changes?