Skip to content

Move min_max unit tests to slt#10539

Merged
jayzhan211 merged 2 commits intoapache:mainfrom
xinlifoobar:dev/xinli1/min_max
May 16, 2024
Merged

Move min_max unit tests to slt#10539
jayzhan211 merged 2 commits intoapache:mainfrom
xinlifoobar:dev/xinli1/min_max

Conversation

@xinlifoobar
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

This change is part of #10384

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels May 16, 2024
Comment thread datafusion/sqllogictest/test_files/aggregate.slt
Copy link
Copy Markdown
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayzhan211 jayzhan211 merged commit 357987f into apache:main May 16, 2024
@jayzhan211
Copy link
Copy Markdown
Contributor

Thanks @xinlifoobar and @yyy1000

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Move min_max unit tests to slt

* Enrich comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants