Handle dictionary values in ScalarValue serde#10563
Merged
thinkharderdev merged 3 commits intoapache:mainfrom May 17, 2024
Merged
Handle dictionary values in ScalarValue serde#10563thinkharderdev merged 3 commits intoapache:mainfrom
thinkharderdev merged 3 commits intoapache:mainfrom
Conversation
comphead
approved these changes
May 17, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @thinkharderdev
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Handle dictionary values in ScalarValue serde * Do not panic on failed physical expr decoding (apache#241) * revert clippy change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10562
Rationale for this change
What changes are included in this PR?
ScalarValuewhich includes nested dictionary fieldsAre these changes tested?
Yes
Are there any user-facing changes?
Protobuf message for
ScalarNestedValueis changed but in backward compatible way