Merged
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
physical-expr
alamb
reviewed
May 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you for this PR @jayzhan211
I think the actual values and their order is important in these tests as it covers various corner cases and thus the new tests in sql I think may not retain the same coverage
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
comphead
approved these changes
May 23, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @jayzhan211
Extra kudos for adding comments to the tests
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* move median test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add more test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10384 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?