Update cli Dockerfile to a newer ubuntu release, newer rust release#10638
Update cli Dockerfile to a newer ubuntu release, newer rust release#10638alamb merged 1 commit intoapache:mainfrom
Conversation
| # under the License. | ||
|
|
||
| FROM rust:1.73-bullseye as builder | ||
| FROM rust:1.78-bookworm as builder |
There was a problem hiding this comment.
The workspace.package in the Cargo.toml is still 1.73. https://github.com/apache/datafusion/blob/main/Cargo.toml#L53
I am fine with updating the Debian version, but updating the Rust version might require more thoughts or having more extensive implications cc @alamb @andygrove
There was a problem hiding this comment.
The Rust version update is only for the build of the CLI. Nothing more. It's not related to the MSRV of DataFusion unless the build of the CLI is the litmus test that the MSRV we have actually builds and runs.
There was a problem hiding this comment.
The Rust version update is only for the build of the CLI. Nothing more. It's not related to the MSRV of DataFusion unless the build of the CLI is the litmus test that the MSRV we have actually builds and runs.
I think the MSRV is verified via a CI job:
datafusion/.github/workflows/rust.yml
Lines 556 to 584 in 4b7b5ab
Which issue does this PR close?
Closes #10472
Rationale for this change
The current Dockerfile is based on a pretty old ubuntu release which doesn't build when run on a newer ubuntu release. I can see no good reason why the cli should be built using old ubuntu and rust versions.
What changes are included in this PR?
Dockerfile update.
Are these changes tested?
Built and tested locally on wsl2/ubuntyu 22.04.4
Are there any user-facing changes?
No