fix wrong type validation on unnest expr#10657
Merged
alamb merged 1 commit intoapache:mainfrom May 25, 2024
Merged
Conversation
duongcongtoai
commented
May 24, 2024
| } = original_expr.transform_up(|expr: Expr| { | ||
| if let Expr::Unnest(Unnest { expr: ref arg }) = expr { | ||
| let (data_type, _) = expr.data_type_and_nullable(input.schema())?; | ||
| let (data_type, _) = arg.data_type_and_nullable(input.schema())?; |
Contributor
Author
There was a problem hiding this comment.
validation should happen for expr inside unnest, not the unnest expr itself
alamb
approved these changes
May 25, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
👍 -- thanks @duongcongtoai
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
May 26, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10656
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?