refactor: simplify converting List DataTypes to ScalarValue#10675
Merged
jayzhan211 merged 1 commit intoapache:mainfrom May 26, 2024
Merged
refactor: simplify converting List DataTypes to ScalarValue#10675jayzhan211 merged 1 commit intoapache:mainfrom
ScalarValue#10675jayzhan211 merged 1 commit intoapache:mainfrom
Conversation
jonahgao
commented
May 26, 2024
| new_null_array( | ||
| &DataType::FixedSizeList( | ||
| Arc::new(Field::new("item", field.data_type().clone(), true)), | ||
| 1, |
Member
Author
There was a problem hiding this comment.
Here, it should be the fixed length instead of always being 1.
alamb
approved these changes
May 26, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jonahgao -- this makes sense to me and I think makes the code look much nicer.
@jayzhan211 if you have time can you also give this PR a review?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
May 26, 2024
Member
Author
|
Thank you for the reviewing @alamb @jayzhan211 ❤️ |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
ScalarValue::try_from(dt: &DataType)is commonly used to create a NULLScalarValuefor a given DataType.The processing of List DataTypes is a bit complex and can be simplified.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No