Merged
Conversation
ozankabak
approved these changes
May 30, 2024
Contributor
ozankabak
left a comment
ozankabak
left a comment
There was a problem hiding this comment.
LGTM, thank you for this simplification.
Contributor
viirya
approved these changes
May 30, 2024
Member
|
Looks good to me. I don't see that SortMergeJoin is required to use this trait. |
comphead
reviewed
May 30, 2024
| evaluate_partition_prefix( | ||
| partitions, | ||
| &[col("a").eq(lit("foo")).and((col("b").eq(lit("bar"))))], | ||
| &[col("a").eq(lit("foo")).and(col("b").eq(lit("bar")))], |
Contributor
There was a problem hiding this comment.
this already fixed. twice :)
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Remove eager trait * Update helpers.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
EagerJoinStreamtrait is currently implemented only bySymmetricHashJoin. It was initially designed to be open-ended for other joins that could potentially work with an eager polling strategy. However, this strategy does not provide significant benefits or serve as a better alternative to other strategies. It is specifically suited to the nature ofSymmetricHashJoin. Therefore, the implementation has been moved directly toSymmetricHashJoin.Although it was suggested that
SortMergeJoinmight utilize this strategy, it does not require such a polling mechanism.For simplification, this PR removes the redundant trait implementation and moves the existing implementation to where it is actually needed. If this trait is being utilized downstream, please share your thoughts.
What changes are included in this PR?
Removed
EagerJoinStreamand moved its implementation toSymmetricHashJoin.Removed the
handle_async_statemacro, which does not simplify any complexity.Are these changes tested?
Are there any user-facing changes?
There are no user-facing changes. This PR involves internal refactoring for simplification and does not impact public APIs.