fix(CLI): can not create external tables with format options#10739
Merged
alamb merged 1 commit intoapache:mainfrom May 31, 2024
Merged
fix(CLI): can not create external tables with format options#10739alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
Good catch 👍🏻 This explicit setup may not be very user-friendly, but it's necessary since we accept file formats directly from |
alamb
approved these changes
May 31, 2024
Member
Author
|
Thanks for the review @berkaysynnada @comphead @alamb |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10737.
Rationale for this change
When setting format options for
TableOptions,datafusion/datafusion-cli/src/exec.rs
Line 376 in 09dde27
the
current_formatofTableOptionsmust already exist, which means set_file_format must be called with a non-none file type first.datafusion/datafusion/common/src/config.rs
Lines 1185 to 1187 in 09dde27
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No