Minor: Remove code duplication in memory_limit derivation for datafusion-cli#10814
Merged
jonahgao merged 4 commits intoapache:mainfrom Jun 7, 2024
Merged
Minor: Remove code duplication in memory_limit derivation for datafusion-cli#10814jonahgao merged 4 commits intoapache:mainfrom
memory_limit derivation for datafusion-cli#10814jonahgao merged 4 commits intoapache:mainfrom
Conversation
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…usion-cli (apache#10814) * Fix: Sort Merge Join crashes on TPCH Q21 * Fix LeftAnti SMJ join when the join filter is set * rm dbg * Minor: Remove code duplication in `memory_limit` derivation for datafusion-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Remove duplicated code to create Greedy memory pool if no pool set
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?