feat: improve type inference for WindowFrame#13059
Merged
goldmedal merged 3 commits intoapache:mainfrom Oct 25, 2024
Merged
Conversation
notfilippo
commented
Oct 22, 2024
jcsherin
reviewed
Oct 22, 2024
jcsherin
reviewed
Oct 23, 2024
Contributor
|
The substrait plan in the original reproducer now contains the expected window frame values for |
Contributor
|
@notfilippo Thanks, squashed three bugs with this refactor 🚀. cc @alamb |
goldmedal
reviewed
Oct 23, 2024
Contributor
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @notfilippo -- overall looks good to me but I got some problems when trying to add more sqllogictests.
goldmedal
approved these changes
Oct 24, 2024
Contributor
There was a problem hiding this comment.
Thanks @notfilippo and @jcsherin for reviewing. I just have one minor question #13059 (comment) . Others LGTM 👍.
Member
Author
|
@goldmedal I've removed SingleQuotedString according to #13059 (comment). |
Contributor
|
Thanks @notfilippo |
Contributor
|
Thanks again @notfilippo @jcsherin 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11432
Closes #12982
Rationale for this change
This tried to fix the liked issue by improving the type inference when creating window frame from sqlparser.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No API changes but potentially a new behaviour introduced that could break some existing code.