Merged
Conversation
peter-toth
force-pushed
the
improve-cse-stats
branch
from
ed8d596 to
cc68012
Compare
Contributor
Author
|
@alamb, this is just a small improvement to CSE. |
alamb
approved these changes
Oct 24, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @peter-toth -- I found the new formulation easier to reason about and understand
Contributor
Author
|
Thank you @alamb for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11194.
Rationale for this change
We don't need to store the exact number of sure and conditional evaluations in
NodeStatsduring CSE.What changes are included in this PR?
This PR adds a new
NodeEvaluationenum to track evaluation.Are these changes tested?
Yes, with existing UTs.
Are there any user-facing changes?
No.