docs: Add alternative syntax for extract, trim and substring.#13143
Merged
alamb merged 1 commit intoapache:mainfrom Oct 29, 2024
Merged
docs: Add alternative syntax for extract, trim and substring.#13143alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
documentation
findepi
approved these changes
Oct 28, 2024
| .with_standard_argument("str", Some("String")) | ||
| .with_argument("trim_str", "String expression to operate on. Can be a constant, column, or function, and any combination of operators. _Default is whitespace characters._") | ||
| .with_alternative_syntax("trim(BOTH trim_str FROM str)") | ||
| .with_alternative_syntax("trim(trim_str FROM str)") |
Member
There was a problem hiding this comment.
Does this deserve new SLT test cases?
Contributor
Author
There was a problem hiding this comment.
I grabbed the syntax from an slt test :)
Contributor
|
lgtm 👍 |
jonathanc-n
approved these changes
Oct 28, 2024
Contributor
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
This looks good to me. We're pretty close!
Omega359
changed the title
alamb
approved these changes
Oct 29, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Omega359 @findepi and @jonathanc-n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #13139, discussed in #13036
Rationale for this change
Complete documentation for functions with alternative syntax
What changes are included in this PR?
doc updates only
Are these changes tested?
Yes.
Are there any user-facing changes?
Documentation