added "DEFAULT_CLI_FORMAT_OPTIONS" for cli and sqllogic test#14052
Merged
jonahgao merged 3 commits intoapache:mainfrom Jan 11, 2025
Merged
added "DEFAULT_CLI_FORMAT_OPTIONS" for cli and sqllogic test#14052jonahgao merged 3 commits intoapache:mainfrom
jonahgao merged 3 commits intoapache:mainfrom
Conversation
jonahgao
approved these changes
Jan 9, 2025
| SELECT MAP(['POST', 'HEAD', 'PATCH'], [41, 33, null]); | ||
| ---- | ||
| {POST: 41, HEAD: 33, PATCH: } | ||
| {POST: 41, HEAD: 33, PATCH: NULL} |
Member
There was a problem hiding this comment.
It is more human-readable to me.
| _ => { | ||
| let f = ArrayFormatter::try_new(col.as_ref(), &DEFAULT_FORMAT_OPTIONS); | ||
| let f = | ||
| ArrayFormatter::try_new(col.as_ref(), &DEFAULT_CLI_FORMAT_OPTIONS); |
Member
There was a problem hiding this comment.
This change makes it consistent with
datafusion/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs
Lines 198 to 201 in 61afb0d
Member
|
Thanks @jatin510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13872.
Discussions on PR: #14046
Rationale for this change
The null values are printed blank, now they will be printed as "NULL".
Before:
Now:
What changes are included in this PR?
A
DEFAULT_CLI_FORMAT_OPTIONSis added for proper formatting in cli for the null valuesAre these changes tested?
Yes, Updated the slt test files.
Are there any user-facing changes?
Yes
Breaking changes in cli