-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix verification script and extended tests due to rustup changes
#14990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−3
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e1ca4b7
Fix rustup toolchain errors
alamb 18e6dde
Use standard builder setup in extended tests
alamb 438b582
fix yaml
alamb 0ed0e0a
sprinkle sudo
alamb 166cad9
Revert "sprinkle sudo"
alamb a20cd82
no contianer
alamb 6a390ba
use rust container
alamb eea398c
fix extended jobs
alamb 509adcd
fix
alamb 96b63db
Update .github/workflows/extended.yml
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,8 +117,11 @@ test_source_distribution() { | |
|
|
||
| # build and test rust | ||
|
|
||
| # install the needed version of rust defined in rust-toolchain.toml | ||
| rustup toolchain install | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the recommended fix from |
||
|
|
||
| # raises on any formatting errors | ||
| rustup component add rustfmt --toolchain stable | ||
| rustup component add rustfmt | ||
| cargo fmt --all -- --check | ||
|
|
||
| # Clone testing repositories into the expected location | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.