Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions .github/workflows/extended.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,28 @@ concurrency:
#
# We still run them as they provide important coverage to ensure correctness
# in the (very rare) event of a hash failure or sqlite library query failure.
on:
push:

# TEMP for testing
on: [push, pull_request]
# on:
# push:
Comment thread
alamb marked this conversation as resolved.
Outdated

jobs:
# Check crate compiles and base cargo check passes
linux-build-lib:
name: linux build test
runs-on: ubuntu-latest
container:
Copy link
Copy Markdown
Contributor Author

@alamb alamb Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes this job consistent with all the other CI jobs that use the rust container

image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
fetch-depth: 1
- name: Install Rust
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source $HOME/.cargo/env
rustup default stable
- name: Install Protobuf Compiler
run: sudo apt-get install -y protobuf-compiler
- name: Setup Rust toolchain
Comment thread
alamb marked this conversation as resolved.
Outdated
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Prepare cargo build
run: |
cargo check --profile ci --all-targets
Expand All @@ -58,20 +60,19 @@ jobs:
name: cargo test 'extended_tests' (amd64)
needs: linux-build-lib
runs-on: ubuntu-latest
container:
image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
fetch-depth: 1
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be
- name: Install Rust
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source $HOME/.cargo/env
rustup default stable
- name: Install Protobuf Compiler
run: sudo apt-get install -y protobuf-compiler
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: stable
# For debugging, test binaries can be large.
- name: Show available disk space
run: |
Expand Down
5 changes: 4 additions & 1 deletion dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,11 @@ test_source_distribution() {

# build and test rust

# install the needed version of rust defined in rust-toolchain.toml
rustup toolchain install
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the recommended fix from rustup


# raises on any formatting errors
rustup component add rustfmt --toolchain stable
rustup component add rustfmt
cargo fmt --all -- --check

# Clone testing repositories into the expected location
Expand Down