Replace usage of println! with logger macros#2020
Merged
alamb merged 1 commit intoapache:masterfrom Mar 20, 2022
silence-coding:master
Merged
Replace usage of println! with logger macros#2020alamb merged 1 commit intoapache:masterfrom silence-coding:master
println! with logger macros#2020alamb merged 1 commit intoapache:masterfrom
silence-coding:master
Conversation
Contributor
Author
|
The reason for using info is that I/O exceptions often occur. Errors caused by error files are very common. Therefore, warn is not necessary. |
alamb
approved these changes
Mar 16, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @silence-coding - I agree println! is not ideal and logging is much better
I think this PR is an improvement -- maybe warn! or error! would be better still
| partition_col_proj, | ||
| ) { | ||
| println!( | ||
| info!( |
Contributor
There was a problem hiding this comment.
What would you think about using warn! or error!here instead ofinfo!`?
Contributor
Author
There was a problem hiding this comment.
What would you think about using
warn!or error!here instead ofinfo!`?
It's all acceptable to me except println
jimexist
changed the title
println! with logger macros
Contributor
|
I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The println macro used in the code is changed to the info macro.