Merged
Conversation
Contributor
Author
|
Locally, the perf impact on the stats_merge benchmark is: |
AdamGS
force-pushed
the
adamg/stats-in-place-min-max
branch
from
8324b4d to
e4f4dba
Compare
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
AdamGS
force-pushed
the
adamg/stats-in-place-min-max
branch
from
e4f4dba to
4e420d6
Compare
Dandandan
approved these changes
Apr 2, 2026
Contributor
|
run benchmark stats_merge |
Contributor
|
run benchmark sql_planner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing adamg/stats-in-place-min-max (2fb0a43) to bc2b36c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing adamg/stats-in-place-min-max (2fb0a43) to bc2b36c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
|
Benchmark results looks good to me -- thanks @AdamGS and @Dandandan |
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? Follow up of apache#20768. ## Rationale for this change `Precision::min/max` allocates a lot of new `ScalarValues`, and it can be done in place. While running the `sql_planner` benchmark, it seems like for clickbench `Statistics::try_merge_iter` is a significant part of the runtime, and this PR improves that part by about 20-25% locally. ## What changes are included in this PR? Introduces a couple of of new internal functions to calculate the min/max of a `Precision` in-place. ## Are these changes tested? Existing general tests, and a few new unit tests. ## Are there any user-facing changes? None --------- Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up of #20768.
Rationale for this change
Precision::min/maxallocates a lot of newScalarValues, and it can be done in place.While running the
sql_plannerbenchmark, it seems like for clickbenchStatistics::try_merge_iteris a significant part of the runtime, and this PR improves that part by about 20-25% locally.What changes are included in this PR?
Introduces a couple of of new internal functions to calculate the min/max of a
Precisionin-place.Are these changes tested?
Existing general tests, and a few new unit tests.
Are there any user-facing changes?
None