Skip to content

Fix: allow coercion from Binary and LargeBinary into BinaryView #21800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bert-beyondloops wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

Fix: allow coercion from Binary and LargeBinary into BinaryView #21800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions datafusion/expr/src/type_coercion/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,8 @@ fn coerced_from<'a>(
(Utf8View, Utf8 | LargeUtf8 | Null) => Some(type_into.clone()),
// Any type can be coerced into strings
(Utf8 | LargeUtf8, _) => Some(type_into.clone()),
// We can go into a BinaryView from a Binary or LargeBinary
(BinaryView, Binary | LargeBinary | Null) => Some(type_into.clone()),
(Null, _) if can_cast_types(type_from, type_into) => Some(type_into.clone()),

(List(_), FixedSizeList(_, _)) => Some(type_into.clone()),
Expand Down Expand Up @@ -956,6 +958,20 @@ mod tests {
let cases = vec![
(DataType::Utf8View, DataType::Utf8),
(DataType::Utf8View, DataType::LargeUtf8),
(DataType::Utf8View, DataType::Null),
];

for case in cases {
assert_eq!(coerced_from(&case.0, &case.1), Some(case.0));
}
}

#[test]
fn test_binary_conversion() {
let cases = vec![
(DataType::BinaryView, DataType::Binary),
(DataType::BinaryView, DataType::LargeBinary),
(DataType::BinaryView, DataType::Null),
];

for case in cases {
Expand Down
Loading
⚡