Draft
Conversation
Several jobs in rust.yml rebuild dependencies cold on every run because they don't attach Swatinem/rust-cache. The workflow also maintained four separate cache keys covering roughly the same workspace, and taplo-cli was still being installed from source on every run. - Add read-only Swatinem/rust-cache (shared-key: amd-ci, save-if: false) to the jobs that previously had no dep cache: linux-datafusion-proto-features, linux-cargo-check-datafusion-functions, linux-test-doc, linux-rustdoc, verify-benchmark-results, sqllogictest-postgres, sqllogictest-substrait, config-docs-check, vendor. msrv is intentionally excluded; cargo msrv verify builds against MSRV rust versions, so the amd-ci cache (built with stable) wouldn't match. - Consolidate amd-ci-check, amd-ci-linux-test-example, and amd-ci-clippy onto the shared amd-ci key. linux-test-example and clippy now use save-if: false; linux-build-lib and linux-test remain the savers. - Replace cargo install taplo-cli in cargo-toml-formatting-checks with taiki-e/install-action, matching the pattern already used for wasm-pack and cargo-msrv. - Cache the deterministic tpch-dbgen output in verify-benchmark-results keyed on the dbgen fork and scale factor, skipping the clone + make + dbgen on cache hits. Part of apache#13813. Made-with: Cursor
github-actions
Bot
added
the
development-process
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Several jobs in
.github/workflows/rust.ymlrebuild dependencies cold on every run because they don't attachSwatinem/rust-cache. The workflow also maintained four separate cache keys covering roughly the same workspace, andtaplo-cliwas still being installed from source on every run. Part of #13813.What changes are included in this PR?
Swatinem/rust-cache@v2(shared-key: amd-ci,save-if: false) to the jobs that previously had no dep cache:linux-datafusion-proto-features,linux-cargo-check-datafusion-functions,linux-test-doc,linux-rustdoc,verify-benchmark-results,sqllogictest-postgres,sqllogictest-substrait,config-docs-check,vendor.msrvis intentionally excluded —cargo msrv verifybuilds against MSRV rust versions, so theamd-cicache (built with stable) wouldn't match and would just add download overhead.Consolidate
amd-ci-check,amd-ci-linux-test-example, andamd-ci-clippyonto the sharedamd-cikey.linux-test-exampleandclippynow usesave-if: false;linux-build-libandlinux-testremain the savers.Replace
cargo install taplo-cliincargo-toml-formatting-checkswithtaiki-e/install-action, matching the pattern already used forwasm-packandcargo-msrv.Cache the deterministic
tpch-dbgenoutput inverify-benchmark-resultskeyed on the dbgen fork and scale factor, skipping the clone +make+dbgenon cache hits.No
needs:graph or coverage changes.Are these changes tested?
Validated locally with
actionlint; pre-existing warnings in untouched shell blocks are unchanged. The actual cache behaviour needs to be observed on real CI runs across multiple pushes.Test Evidence
rust.yml Performance (Cold)
rust.yml Performance (Warm)
Are there any user-facing changes?
No — this is CI infrastructure only.
Made with Cursor