minor: Refactor to avoid repeated code in replace_qualifier#2222
Merged
alamb merged 1 commit intoapache:masterfrom Apr 13, 2022
Merged
minor: Refactor to avoid repeated code in replace_qualifier#2222alamb merged 1 commit intoapache:masterfrom
alamb merged 1 commit intoapache:masterfrom
Conversation
andygrove
changed the title
alamb
approved these changes
Apr 13, 2022
| f.is_nullable(), | ||
| ) | ||
| }) | ||
| .map(|f| DFField::from_qualified(qualifier, f.field)) |
Contributor
There was a problem hiding this comment.
not that it matters, but this also saves a copy of field I think 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Reduce code duplication and use existing method
What changes are included in this PR?
Minor refactor of
replace_qualifierto call existingDFField::from_qualifiedmethod.Are there any user-facing changes?
No
No