rewrite approx_median to approx_percentile_cont while planning phase#2262
Merged
andygrove merged 2 commits intoapache:masterfrom Apr 28, 2022
Merged
rewrite approx_median to approx_percentile_cont while planning phase#2262andygrove merged 2 commits intoapache:masterfrom
andygrove merged 2 commits intoapache:masterfrom
Conversation
Member
|
@realno @yahoNanJing fyi since you have both worked on this code. I plan to merge this soon if there are no objections. |
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Jul 5, 2022
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 1, 2022
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2221 .
Rationale for this change
At this moment optimization rule for "approx_median -> approx_percentile_cont" replacement slightly breaks logical plan (expressions inside of aggregate step don't match its output schema) and it works fine in case of one optimizer pass, but while second optimizer pass projection_push_down rule cleans up approximate_percentile_cont.
What changes are included in this PR?
Suggestion is to move function replacement to planning phase - it seems to be more appropriate (we don't actually need the whole execution plan for this, because it's just rewriting of single expression), and there is no need to adjust all aliases / projections / schemas while optimization phase after replacement.
Are there any user-facing changes?
Fixed execution of queries with approx_median aggregate expression / window function / having filter.