Fix outer join output with all-null indices on empty batch#2272
Merged
yjshen merged 5 commits intoapache:masterfrom Apr 21, 2022
Merged
Fix outer join output with all-null indices on empty batch#2272yjshen merged 5 commits intoapache:masterfrom
yjshen merged 5 commits intoapache:masterfrom
Conversation
yjshen
changed the title
alamb
approved these changes
Apr 19, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @yjshen 👍
I ran the initial reproducer provided by @wangxiaoying and confirmed that this PR fixes the issue.
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
* Fix outer join output with all-null indices * refactor test * t1_value * sql * right join
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
* Fix outer join output with all-null indices * refactor test * t1_value * sql * right join qwe
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
* Fix outer join output with all-null indices * refactor test * t1_value * sql * right join qwe qwe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2268.
Rationale for this change
Fix
takeall-null indices from empty batch during join output.What changes are included in this PR?
FIx along with a test.
Are there any user-facing changes?
No.
No.