Remove unnecessary env var for parquet_sql example#2297
Merged
yjshen merged 1 commit intoapache:masterfrom Apr 21, 2022
sergey-melnychuk:patch-1
Merged
Remove unnecessary env var for parquet_sql example#2297yjshen merged 1 commit intoapache:masterfrom sergey-melnychuk:patch-1
yjshen merged 1 commit intoapache:masterfrom
sergey-melnychuk:patch-1
Conversation
andygrove
approved these changes
Apr 20, 2022
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
The example does call datafusion::test_util::parquet_test_data() which would respect this env var if set, but it has a sensible default and it does seem unnecessary to have this documentation. Also, other examples use the same method and we don't suggest setting this env var for those.
yjshen
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.