Merged
Conversation
jackwener
reviewed
Apr 25, 2022
Member
|
It's better to link the related issue if it exists. If it doesn't exist, I think it would be better to create it and link it. |
alamb
reviewed
Apr 25, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @gandronchik I tried this out locally and it seems to have worked well 👍
Nice work
❯ SELECT 1 a UNION ALL SELECT 2;
+---------+
| column0 |
+---------+
| 2 |
| 1 |
+---------+
2 rows in set. Query took 0.048 seconds.I also verified that this behavior (taking the left schema as the output schema) is consistent with postgres:
alamb=# SELECT 1 as a UNION ALL SELECT 2;
a
---
1
2
(2 rows)
alamb=# SELECT 1 as a UNION ALL SELECT 2 as b;
a
---
1
2
(2 rows)The only thing I would like to see is a specific test. The other comments are just suggestions for improvements but not required in my opinion.
Member
|
Hi @gandronchik Do you have time to address the PR feedback here so that we can get your change approved + merged? |
alamb
approved these changes
May 4, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @gandronchik -- looks good now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix UNION schema
example:
SELECT 1 a UNION ALL SELECT 2;
Closes #2083