Support multiple paths for ListingTableScanNode#2775
Merged
alamb merged 2 commits intoapache:masterfrom Jun 24, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
==========================================
- Coverage 84.95% 84.94% -0.01%
==========================================
Files 271 272 +1
Lines 48164 48256 +92
==========================================
+ Hits 40916 40993 +77
- Misses 7248 7263 +15
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 24, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks like a nice change to me -- nice work @Ted-Jiang
cc @liukun4515 feel free to review and merge such PRs too
Contributor
|
FYI @tustvold |
Member
Author
|
@alamb Thanks❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2768.
Rationale for this change
Sometimes we need pass multi-path in
ListingTableScanNode, like in sparkhttps://github.com/apache/spark/blob/a8a765b3f302c078cb9519c4a17912cd38b9680c/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileIndex.scala#L36-L43
Are there any user-facing changes?
will return a vec