fix: correctly calculate join output schema nullability#2803
Merged
xudong963 merged 1 commit intoapache:masterfrom Jun 28, 2022
Merged
fix: correctly calculate join output schema nullability#2803xudong963 merged 1 commit intoapache:masterfrom
xudong963 merged 1 commit intoapache:masterfrom
Conversation
5f1aab4 to
89fa13a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
+ Coverage 85.11% 85.20% +0.09%
==========================================
Files 273 274 +1
Lines 48240 48590 +350
==========================================
+ Hits 41060 41402 +342
- Misses 7180 7188 +8
Continue to review full report at Codecov.
|
andygrove
approved these changes
Jun 28, 2022
xudong963
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2778
Rationale for this change
apache/arrow-rs#1888 in arrow added validation to
RecordBatchif the schema's declared nullability is different than its actual nullability.This caught that the output schema calculation for joins is incorrect -- specifically, LEFT/RIGHT/FULL joins can introduce nulls even if the input schema is not nullable.
For example, given the following non-null input:
This query:
Produces a null on
b(though a is non nullable ifais non nullable in the input) and thusbmust be marked nullableWhat changes are included in this PR?
NULLs introduced in joins in output schema calculationAre there any user-facing changes?
I don't think so (except more correct null schema marking)