Make lit implementation more concise#2838
Merged
andygrove merged 1 commit intoapache:masterfrom Jul 5, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
- Coverage 85.19% 85.18% -0.01%
==========================================
Files 275 275
Lines 48761 48764 +3
==========================================
+ Hits 41541 41542 +1
- Misses 7220 7222 +2
Continue to review full report at Codecov.
|
andygrove
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #2827
Rationale for this change
@andygrove suggested the code in #2828 could be made more concise: https://github.com/apache/arrow-datafusion/pull/2828/files#r912398460
What changes are included in this PR?
make code more concise
Are there any user-facing changes?
No