Skip to content

Make lit implementation more concise#2838

Merged
andygrove merged 1 commit intoapache:masterfrom
alamb:alamb/cleanup
Jul 5, 2022
Merged

Make lit implementation more concise#2838
andygrove merged 1 commit intoapache:masterfrom
alamb:alamb/cleanup

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Jul 5, 2022

Which issue does this PR close?

re #2827

Rationale for this change

@andygrove suggested the code in #2828 could be made more concise: https://github.com/apache/arrow-datafusion/pull/2828/files#r912398460

What changes are included in this PR?

make code more concise

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review July 5, 2022 16:52
@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Jul 5, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2838 (050a3e1) into master (bf7564f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.01%     
==========================================
  Files         275      275              
  Lines       48761    48764       +3     
==========================================
+ Hits        41541    41542       +1     
- Misses       7220     7222       +2     
Impacted Files Coverage Δ
...atafusion/physical-expr/src/expressions/literal.rs 100.00% <100.00%> (ø)
datafusion/expr/src/logical_plan/plan.rs 74.11% <0.00%> (-0.20%) ⬇️
datafusion/common/src/scalar.rs 75.66% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7564f...050a3e1. Read the comment docs.

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@andygrove andygrove merged commit 00a1731 into apache:master Jul 5, 2022
@alamb alamb deleted the alamb/cleanup branch July 6, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants