make regexp_replace early abort with empty input#3648
make regexp_replace early abort with empty input#3648Dandandan merged 1 commit intoapache:masterfrom
Conversation
b840305 to
91ccdc2
Compare
91ccdc2 to
0505d05
Compare
|
Benchmark runs are scheduled for baseline = 0d1cd55 and contender = a9f7cac. a9f7cac is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3647.
Rationale for this change
This PR makes
_regexp_replace_static_pattern_replaceearly abort when any of the given arrays has a size of 0. This is the same behavior for the unspecialized version, but it is hidden under.zip()calls (e.g. if any of the arrays is of zero-length, it stops without producing any input).What changes are included in this PR?
A length check to redirect
fetch_string_argto$EARLY_ABORT. We don't do the length check on the input since when it tries to unfold itself, it will create an empty array.Are there any user-facing changes?
Bug fix (it used to panic).