Skip to content

Fail if field lengths are not same in INTERSECT and EXPECT#3674

Merged
HaoYang670 merged 3 commits intoapache:masterfrom
askoa:intersect-expect
Oct 1, 2022
Merged

Fail if field lengths are not same in INTERSECT and EXPECT#3674
HaoYang670 merged 3 commits intoapache:masterfrom
askoa:intersect-expect

Conversation

@askoa
Copy link
Copy Markdown
Contributor

@askoa askoa commented Oct 1, 2022

Which issue does this PR close?

Closes #3632

Are there any user-facing changes?

Users will see failure if they are using INTERSECT and EXPECT on tables with different field count.

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions labels Oct 1, 2022
xudong963
xudong963 reviewed Oct 1, 2022
View reviewed changes
Comment thread datafusion/expr/src/logical_plan/builder.rs Outdated
xudong963
xudong963 reviewed Oct 1, 2022
View reviewed changes
Comment thread datafusion/core/tests/sql/intersection.rs Outdated
@github-actions github-actions bot removed the core Core DataFusion crate label Oct 1, 2022
xudong963
xudong963 approved these changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @askoa

@xudong963 xudong963 requested a review from HaoYang670 October 1, 2022 11:56
@askoa
Copy link
Copy Markdown
Contributor Author

askoa commented Oct 1, 2022

CI failure unrelated to this PR.

HaoYang670
HaoYang670 approved these changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @askoa !

@HaoYang670 HaoYang670 merged commit 928032f into apache:master Oct 1, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Oct 1, 2022

Benchmark runs are scheduled for baseline = 6d2b417 and contender = 928032f. 928032f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@askoa askoa deleted the intersect-expect branch December 1, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xudong963 xudong963 xudong963 approved these changes

+1 more reviewer

@HaoYang670 HaoYang670 HaoYang670 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

logical-expr Logical plan and expressions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

INTERSECT and EXCEPT don't return an error when 2 sets have the different number of columns

4 participants

@askoa @ursabot @xudong963 @HaoYang670
⚡