Minor: reduce indent level in page filter pruning code#5105
Minor: reduce indent level in page filter pruning code#5105alamb merged 2 commits intoapache:masterfrom
Conversation
alamb
left a comment
There was a problem hiding this comment.
Reviewing with whitespace blind diff I think shows more easily what is changed https://github.com/apache/arrow-datafusion/pull/5105/files?w=1
9c3f400 to
cd8a184
Compare
|
@Ted-Jiang or @tustvold or @thinkharderdev I wonder if you might have time over the next few days to review this (mechanical) PR (in support of trying to get page index enabled by default)? |
|
Benchmark runs are scheduled for baseline = f8607c2 and contender = 8bae10b. 8bae10b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #5104
Rationale for this change
I am working to fix the page pruning logic to handle schemas that are not the same across files. I find the nesting level of the page pruning code hard to work and I want to minimize the diff of the PR that will make actual logic changes to make it easier to review.
What changes are included in this PR?
No functional changes are intended
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No