Skip to content

fix: treat unsupported SQL plans as "not implemented"#5159

Merged
alamb merged 1 commit intoapache:masterfrom
crepererum:crepererum/fix_planner_error_types
Feb 3, 2023
Merged

fix: treat unsupported SQL plans as "not implemented"#5159
alamb merged 1 commit intoapache:masterfrom
crepererum:crepererum/fix_planner_error_types

Conversation

@crepererum
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

--

Rationale for this change

Use the correct error type because API users may rely on that (e.g. to generate appropriate HTTP error codes).

What changes are included in this PR?

Change some errors from Internal to NotImplemented.

Are these changes tested?

SQL test, see changed test.

Are there any user-facing changes?

Improved error types.

Use the correct error type because API users may rely on that (e.g. to
generate appropriate HTTP error codes).
@github-actions github-actions bot added the core Core DataFusion crate label Feb 2, 2023
Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great -- I believe that @tustvold had some opinions on these codes

Copy link
Copy Markdown
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that @tustvold had some opinions on these codes

Did I? 😅 If I did, I don't remember 😆 Looks good to me

Edit: Oh I remember, I wanted to adjust the typing to remove this from being a possibility, but I don't mind this approach either

@alamb alamb merged commit 379cf39 into apache:master Feb 3, 2023
@ursabot
Copy link
Copy Markdown

ursabot commented Feb 3, 2023

Benchmark runs are scheduled for baseline = 1ec2a83 and contender = 379cf39. 379cf39 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants