fix: treat unsupported SQL plans as "not implemented"#5159
fix: treat unsupported SQL plans as "not implemented"#5159alamb merged 1 commit intoapache:masterfrom
Conversation
Use the correct error type because API users may rely on that (e.g. to generate appropriate HTTP error codes).
There was a problem hiding this comment.
I believe that @tustvold had some opinions on these codes
Did I? 😅 If I did, I don't remember 😆 Looks good to me
Edit: Oh I remember, I wanted to adjust the typing to remove this from being a possibility, but I don't mind this approach either
|
Benchmark runs are scheduled for baseline = 1ec2a83 and contender = 379cf39. 379cf39 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
--
Rationale for this change
Use the correct error type because API users may rely on that (e.g. to generate appropriate HTTP error codes).
What changes are included in this PR?
Change some errors from
InternaltoNotImplemented.Are these changes tested?
SQL test, see changed test.
Are there any user-facing changes?
Improved error types.