Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237#5244
Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237#5244alamb merged 3 commits intoapache:masterfrom
Conversation
Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version. - [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases) - [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md) - [Commits](risinglightdb/sqllogictest-rs@v0.11.1...v0.12.0) --- updated-dependencies: - dependency-name: sqllogictest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ster/sqllogictest-0.12.0
alamb
added
development-process
github-actions
bot
added
core
|
|
||
| use sqllogictest::{DBOutput, DefaultColumnType}; | ||
|
|
||
| pub type DFColumnType = DefaultColumnType; |
There was a problem hiding this comment.
DBOutput is now generic to support a custom column type description.
cc @melgenek as I think you were discussing this on a previous PR
There was a problem hiding this comment.
Yes, sqllogictest was updated.
The update in this pr doesn't:
- validate types by default. By default, any types are successful as long as it can be parsed. Validation can be enabled with
runner.with_column_validator(strict_column_validator); --completedoesn't fill in the expected types. I need to create another pr insqllogictest-rs.
Anyway, I was going to work on #4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.
|
|
||
| use sqllogictest::{DBOutput, DefaultColumnType}; | ||
|
|
||
| pub type DFColumnType = DefaultColumnType; |
There was a problem hiding this comment.
Yes, sqllogictest was updated.
The update in this pr doesn't:
- validate types by default. By default, any types are successful as long as it can be parsed. Validation can be enabled with
runner.with_column_validator(strict_column_validator); --completedoesn't fill in the expected types. I need to create another pr insqllogictest-rs.
Anyway, I was going to work on #4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.
|
Benchmark runs are scheduled for baseline = eda875b and contender = 8bc035b. 8bc035b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ache#5244) * Update sqllogictest requirement from 0.11.1 to 0.12.0 Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version. - [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases) - [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md) - [Commits](risinglightdb/sqllogictest-rs@v0.11.1...v0.12.0) --- updated-dependencies: - dependency-name: sqllogictest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fmt --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 participants
Which issue does this PR close?
Closes #5237
Rationale for this change
Keep up with upstream libraries (thanks @xxchan !)
What changes are included in this PR?
Are these changes tested?
in CI
Are there any user-facing changes?
No