Add SQL function overload LOG(base, x) for logarithm of x to base

[comphead]

Which issue does this PR close?

Closes #5206 .

Rationale for this change

Add SQL function overload LOG(base, x) for logarithm of x to base

What changes are included in this PR?

Are these changes tested?

Test included

Are there any user-facing changes?

No

[comphead]

@stuartcarnie @alamb with log function we have some discrepancy with PG, its not brought up with this PR, it existed before

❯ select log(1, 64), log(0);
+-------------------------+---------------+
| log(Int64(1),Int64(64)) | log(Int64(0)) |
+-------------------------+---------------+
| inf                     | -inf          |
+-------------------------+---------------+

whereas PostgresSQL doesn't allow queries like that and fail the query

[alamb]

whereas PostgresSQL doesn't allow queries like that and fail the query

For anyone else who is curious, here is what postgres does with this query:

postgres=# select log(0);
ERROR:  cannot take logarithm of zero
postgres=# select log(1, 64);
ERROR:  division by zero

[alamb]

Thank you very much for this contribution @comphead

[comphead]

whereas PostgresSQL doesn't allow queries like that and fail the query

For anyone else who is curious, here is what postgres does with this query:

postgres=# select log(0);
ERROR:  cannot take logarithm of zero
postgres=# select log(1, 64);
ERROR:  division by zero

@alamb would you like to solve edgecases as part of this PR or another one?

[alamb]

@alamb would you like to solve edgecases as part of this PR or another one?

A different one, please

[alamb]

Suggested change

	## Scalar Tests
	## Scalar Function Tests

[comphead]

Done

[alamb]

Can you please add the test cases you identified in the PR here (log(0), log(1, 64)) as well to document the behavior and also file a ticket to document the discrepancy?

[comphead]

Done, filed #5259

[alamb]

Thanks @comphead -- this looks really great. cc @stuartcarnie

[stuartcarnie]

Looks great, thanks @comphead 🙏

I tried to look at the source of PostgreSQL, to see the implementation of their log function, but can't search on my phone 😏

[alamb]

Thanks again @comphead

[ursabot]

Benchmark runs are scheduled for baseline = 0f95966 and contender = 8a609dc. 8a609dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java