Skip to content

Minor: Add fetch to SortExec display#5279

Merged
thinkharderdev merged 2 commits intoapache:masterfrom
coralogix:sort-exec-display
Feb 14, 2023
Merged

Minor: Add fetch to SortExec display#5279
thinkharderdev merged 2 commits intoapache:masterfrom
coralogix:sort-exec-display

Conversation

@thinkharderdev
Copy link
Copy Markdown
Contributor

@thinkharderdev thinkharderdev commented Feb 14, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

If limit gets pushed down into SortExec show it in the execution plan display

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

SortExec display now has fetch in it

No

@github-actions github-actions bot added the core Core DataFusion crate label Feb 14, 2023
thinkharderdev
thinkharderdev commented Feb 14, 2023
View reviewed changes
Comment thread datafusion/core/src/physical_plan/sorts/sort.rs
DisplayFormatType::Default => {
let expr: Vec<String> = self.expr.iter().map(|e| e.to_string()).collect();
write!(f, "SortExec: [{}]", expr.join(","))
match self.fetch {
Copy link
Copy Markdown
Contributor Author

@thinkharderdev thinkharderdev Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change, everything else is just updating tests

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 14, 2023
@thinkharderdev thinkharderdev merged commit 9a6b76e into apache:master Feb 14, 2023
@thinkharderdev thinkharderdev deleted the sort-exec-display branch February 14, 2023 16:25
@ursabot
Copy link
Copy Markdown

ursabot commented Feb 14, 2023

Benchmark runs are scheduled for baseline = c0defeb and contender = 9a6b76e. 9a6b76e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@thinkharderdev @jiangzhx
Minor: Add fetch to SortExec display (apache#5279)
bb5b792 
* Add fetch to SortExec display

* fix sqllogictests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dandandan Dandandan Dandandan approved these changes

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thinkharderdev @ursabot @Dandandan @andygrove
⚡