Fix the potential bug of check_all_column_from_schema#5287
Fix the potential bug of check_all_column_from_schema#5287alamb merged 2 commits intoapache:mainfrom
Conversation
|
Benchmark runs are scheduled for baseline = fed4019 and contender = f154a9a. f154a9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
* Fix the potential bug of check_all_column_from_schema * rename contain_column to is_column_from_schema
Which issue does this PR close?
Closes #.
Rationale for this change
The
check_all_column_from_schemais used to check if columns are all in the schema.It is based on
index_of_column. Giving the column,index_of_columnhas three result:1and3will return Error. Incheck_all_column_from_schema, we need distinguish these two, but currently we don't do it. This pr will fix it.What changes are included in this PR?
index_of_column_by_nameto returnResult<Option<usize>>.is_column_from_schema, andcheck_all_column_from_schemacalls it.Are these changes tested?
Yes
Are there any user-facing changes?