Skip to content

fix: largeUtf8 don't support is distinct from#5993

Merged
alamb merged 1 commit intoapache:mainfrom
jackwener:fix_is_ditinct_from
Apr 14, 2023
Merged

fix: largeUtf8 don't support is distinct from#5993
alamb merged 1 commit intoapache:mainfrom
jackwener:fix_is_ditinct_from

Conversation

@jackwener
Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #5991.

Rationale for this change

After I fix type coercion for largeUtf8/utf8, I find largeutf8 is distinct from largeutf8 still fail.

What changes are included in this PR?

Are these changes tested?

add slt

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Apr 13, 2023
@alamb alamb merged commit 48c0a2b into apache:main Apr 14, 2023
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 14, 2023

Thanks @jackwener @r4ntix and @yjshen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LargeUTF8 failed in is distinct from

4 participants