feat: Remove compact row since it's no longer used#6021
Merged
yjshen merged 4 commits intoapache:mainfrom Apr 17, 2023
Merged
Conversation
comphead
reviewed
Apr 15, 2023
|
|
||
| impl<'a> RowAccessor<'a> { | ||
| /// new | ||
| pub fn new(schema: &Schema, row_type: RowType) -> Self { |
Contributor
There was a problem hiding this comment.
Thanks for the PR. This is always great to cut out the unused code. For public functions though it can be a user interface change for downstream projects btw?
Member
Author
There was a problem hiding this comment.
Thanks for bringing this out! I've created an issue, added an API change label, and edited the PR descriptions accordingly.
yjshen
changed the title
alamb
approved these changes
Apr 17, 2023
| /// | ||
| /// [Compact]: datafusion_row::layout::RowType::Compact | ||
| /// [WordAligned]: datafusion_row::layout::RowType::WordAligned | ||
| /// [Arrow-row]: OwnedRow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6024.
Rationale for this change
While reviewing the latest code changes over aggregation, I found the original
RowType::Compactrow is no longer used as grouping key representation in AggregateExec; therefore remove it and re-document the row format in DataFusion a little bit.What changes are included in this PR?
Remove the deprecated compact row layout as well as the related implementations.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
Yes, the
RowTypeenum is removed, with its usages removed from related row APIs. After this change, the only layout forRowLayoutin DataFusion is the word-aligned layout.