feat: allow TableScan without projection#6032
Merged
yjshen merged 4 commits intoapache:mainfrom Apr 19, 2023
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
r4ntix
approved these changes
Apr 17, 2023
Member
Author
|
cc @andygrove and @nseekhao |
jackwener
approved these changes
Apr 18, 2023
Co-authored-by: jakevin <jakevingoo@gmail.com>
yjshen
approved these changes
Apr 19, 2023
Member
Author
|
Thanks for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to GreptimeTeam/greptimedb#1396
Rationale for this change
Allow table scan without projection. It should be a constrain as the projection field in
TableScanplan is optional:https://github.com/apache/arrow-datafusion/blob/3ad7734a7e5b1844b02f1374d0dc1c441bef216d/datafusion/expr/src/logical_plan/plan.rs#L1396-L1403
What changes are included in this PR?
Don't throw error when there is no projection in
TableScan.Are these changes tested?
Yes
Are there any user-facing changes?
Yes but not breaking