async call not work when use zipkin

[maxiaoguang64]

dubbo version 2.6.x
zipkin plugin version 5.6.1

result.hasException() will call future.get() to wait result

[maxiaoguang64]

@chickenlj can we disscus this

[chickenlj]

result.hasException() will call future.get() to wait result

Sorry, but I don't understand why result.hasException will trigger future.get().

Can you provide the complete code implementation which the above snippet belongs to?

[maxiaoguang64]

@chickenlj
i am sorry, i use dubbo 2.7.0-SNAPSHOT.

but 2.7.0-RELEASE already fix it.

Is this necessary?
oneway and async are difference.


call tracing consumer--->provider1--->provider2
use async call
but i can't wait result.

[maxiaoguang64]

@chickenlj can i do something?

[chickenlj]

but 2.7.0-RELEASE already fix it.

Yes, the bug you reported will be fixed in 2.7.1 release.

Is this necessary?

You can use RpcContext.getCompletableFuture() and add callback to CompletableFuture directly.
And I would recommend you record the Finish Span in Filter.onResponse, it works for both sync and async scenario, you do not need to register any callback. Whenever onResponse is called, indicates the actual result returns.