[Dubbo-2017]Fix redis auth problem for RedisProtocol#2018
Merged
chickenlj merged 7 commits intoapache:masterfrom Jul 31, 2018
Merged
[Dubbo-2017]Fix redis auth problem for RedisProtocol#2018chickenlj merged 7 commits intoapache:masterfrom
chickenlj merged 7 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
============================================
+ Coverage 52.14% 54.06% +1.91%
- Complexity 4902 5148 +246
============================================
Files 562 570 +8
Lines 25216 25600 +384
Branches 4449 4506 +57
============================================
+ Hits 13150 13840 +690
+ Misses 10060 9691 -369
- Partials 2006 2069 +63
Continue to review full report at Codecov.
|
kimmking
reviewed
Jul 15, 2018
| final JedisPool jedisPool = new JedisPool(config, url.getHost(), url.getPort(DEFAULT_PORT), | ||
| url.getParameter(Constants.TIMEOUT_KEY, Constants.DEFAULT_TIMEOUT)); | ||
| if (StringUtils.isBlank(url.getPassword())) { | ||
| jedisPool = new JedisPool(config, url.getHost(), url.getPort(DEFAULT_PORT), |
Member
There was a problem hiding this comment.
You can use StringUtils.isBlank(url.getPassword())?: style to replace if style, reduce reduplicated codes.
|
LGTM. &READY-TO-MERGE& |
|
BTW, need to merge to 2.6.x? @ningyu1 |
Contributor
Author
|
@diecui1202 Yes |
Contributor
Author
|
@diecui1202 merge to 2.6.x PR: #2146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Access redis using a password. #2017
Brief changelog
Fix redis auth problem for RedisProtocol, add parameter
db.indexfor url.Verifying this change
modify: RedisProtocol.java
modify: RedisRegistry.java
add UT: RedisProtocolTest.testAuthRedis
add UT: RedisProtocolTest.testWrongAuthRedis
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.