Skip to content

[dubbo-parent] Fix demo code error in readme file#2122

Merged
ralf0131 merged 1 commit intoapache:masterfrom
alexlavigne:master
Jul 24, 2018
Merged

[dubbo-parent] Fix demo code error in readme file#2122
ralf0131 merged 1 commit intoapache:masterfrom
alexlavigne:master

Conversation

@alexlavigne
Copy link
Copy Markdown
Contributor

correting the demo code in readme

What is the purpose of the change

correting the demo code in readme

Brief changelog

correting the demo code in readme

Verifying this change

Verified.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

correting the demo code in readme
@ralf0131
Copy link
Copy Markdown
Contributor

LGTM, thanks for the pull request!

@ralf0131
Copy link
Copy Markdown
Contributor

I am re-triggering the CI, because some of the UT are unstable under Java 10.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2122 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2122      +/-   ##
============================================
- Coverage     54.19%   54.14%   -0.05%     
+ Complexity     5085     5080       -5     
============================================
  Files           559      559              
  Lines         24922    24922              
  Branches       4442     4442              
============================================
- Hits          13506    13494      -12     
- Misses         9380     9388       +8     
- Partials       2036     2040       +4
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 45.83% <0%> (-4.17%) 3% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 10% <0%> (-3%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88.88% <0%> (+5.55%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6e6f3...2e81d58. Read the comment docs.

@ralf0131 ralf0131 merged commit eed3db3 into apache:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants