[dubbo-parent] Fix demo code error in readme file#2122
Merged
ralf0131 merged 1 commit intoapache:masterfrom Jul 24, 2018
Merged
[dubbo-parent] Fix demo code error in readme file#2122ralf0131 merged 1 commit intoapache:masterfrom
ralf0131 merged 1 commit intoapache:masterfrom
Conversation
correting the demo code in readme
Contributor
|
LGTM, thanks for the pull request! |
Contributor
|
I am re-triggering the CI, because some of the UT are unstable under Java 10. |
Codecov Report
@@ Coverage Diff @@
## master #2122 +/- ##
============================================
- Coverage 54.19% 54.14% -0.05%
+ Complexity 5085 5080 -5
============================================
Files 559 559
Lines 24922 24922
Branches 4442 4442
============================================
- Hits 13506 13494 -12
- Misses 9380 9388 +8
- Partials 2036 2040 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correting the demo code in readme
What is the purpose of the change
correting the demo code in readme
Brief changelog
correting the demo code in readme
Verifying this change
Verified.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.