Skip to content

[Dubbo-2129]Enable checkstyle and rat plugin in travis#2130

Merged
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:enable_stylecheck_in_travis
Jul 25, 2018
Merged

[Dubbo-2129]Enable checkstyle and rat plugin in travis#2130
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:enable_stylecheck_in_travis

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Jul 25, 2018

What is the purpose of the change

Enable checkstyle and rat plugin in travis, fix #2129

Brief changelog

./mvnw clean package -Dcheckstyle.skip=false -Drat.skip=false

Verifying this change

Travis check license header and code style automatically.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj changed the title Enable checkstyle and rat plugin in travis [Dubbo-2129]Enable checkstyle and rat plugin in travis Jul 25, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2130 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2130      +/-   ##
============================================
+ Coverage     54.03%   54.12%   +0.09%     
- Complexity     5072     5079       +7     
============================================
  Files           559      559              
  Lines         24922    24922              
  Branches       4442     4442              
============================================
+ Hits          13466    13489      +23     
+ Misses         9411     9394      -17     
+ Partials       2045     2039       -6
Impacted Files Coverage Δ Complexity Δ
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-12.5%) 3% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 57.89% <0%> (-1.06%) 18% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 57.74% <0%> (+1.67%) 41% <0%> (+3%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyServer.java 75.4% <0%> (+3.27%) 10% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.25% <0%> (+6.25%) 22% <0%> (+1%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.71% <0%> (+7.14%) 10% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 66.25% <0%> (+8.75%) 21% <0%> (+2%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.52% <0%> (+11.26%) 16% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed3db3...c1d9ae6. Read the comment docs.

@chickenlj chickenlj merged commit 3eae624 into apache:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable ASF header check for Travis CI

2 participants