Skip to content

support char[] for generic invoke #2003 #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonghaishang merged 2 commits into from
Jul 26, 2018
Merged

support char[] for generic invoke #2003 #2137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f31d2
support char[] for generic invoke, #2003
diecui1202 Jul 26, 2018
dc380d1
add null or empty string testcase
diecui1202 Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,17 @@ public static Object compatibleTypeConvert(Object value, Class<?> type) {
} catch (ClassNotFoundException e) {
throw new RuntimeException(e.getMessage(), e);
}
} else if (char[].class.equals(type)) {
// #2003, process string to char array for generic invoke
if (string == null) {
Copy link
Copy Markdown
Member

@zonghaishang zonghaishang Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diecui1202
Please add a null unit test

return null;
}
else {
int len = string.length();
char[] chars = new char[len];
string.getChars(0, len, chars, 0);
return chars;
}
}
} else if (value instanceof Number) {
Number number = (Number) value;
Expand Down
5 changes: 5 additions & 0 deletions dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ public void testCompatibleTypeConvert() throws Exception {

result = CompatibleTypeUtils.compatibleTypeConvert("2011-12-11 12:24:12", Date.class);
assertEquals(new SimpleDateFormat("yyyy-MM-dd HH:mm:ss").parse("2011-12-11 12:24:12"), (Date) result);

result = CompatibleTypeUtils.compatibleTypeConvert("ab", char[].class);
assertEquals(2, ((char[]) result).length);
assertEquals('a', ((char[]) result)[0]);
assertEquals('b', ((char[]) result)[1]);
}

{
Expand Down
⚡