Skip to content

FailoverClusterInvoker 使用泛化调用时,拿取正确的方法名称。#2145

Merged
diecui1202 merged 1 commit intoapache:masterfrom
jin82:master
Aug 9, 2018
Merged

FailoverClusterInvoker 使用泛化调用时,拿取正确的方法名称。#2145
diecui1202 merged 1 commit intoapache:masterfrom
jin82:master

Conversation

@jin82
Copy link
Copy Markdown
Contributor

@jin82 jin82 commented Jul 27, 2018

修复使用FailoverCluster泛化调用时因为methodName得不到配置的重试次数

#2108

What is the purpose of the change

使用FailoverCluster进行泛化调用,FailoverClusterInvoker可以根据泛化的具体方法得到配置的重试次数。

修复使用FailoverCluster泛化调用时因为methodName得不到配置的重试次数
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2145 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2145      +/-   ##
============================================
- Coverage     54.21%   54.16%   -0.06%     
+ Complexity     5096     5093       -3     
============================================
  Files           559      559              
  Lines         24945    24946       +1     
  Branches       4445     4445              
============================================
- Hits          13524    13511      -13     
- Misses         9383     9394      +11     
- Partials       2038     2041       +3
Impacted Files Coverage Δ Complexity Δ
...bo/rpc/cluster/support/FailoverClusterInvoker.java 84.44% <100%> (+0.35%) 7 <0> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-8.34%) 3% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90d95c...697254e. Read the comment docs.

@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented Aug 2, 2018

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants