@Service and @Reference Optimization#2655
Merged
mercyblitz merged 1 commit intoapache:2.6.xfrom Oct 18, 2018
Merged
Conversation
| import com.alibaba.dubbo.config.ProviderConfig; | ||
| import com.alibaba.dubbo.config.RegistryConfig; | ||
| import com.alibaba.dubbo.config.ServiceConfig; | ||
| import com.alibaba.dubbo.config.*; |
Member
There was a problem hiding this comment.
Maybe you should use dubbo code style here ? you can found here : https://github.com/apache/incubator-dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml
remove * please.
| import com.alibaba.dubbo.config.ModuleConfig; | ||
| import com.alibaba.dubbo.config.MonitorConfig; | ||
| import com.alibaba.dubbo.config.RegistryConfig; | ||
| import com.alibaba.dubbo.config.*; |
| throws IllegalStateException { | ||
|
|
||
| String interfaceName; | ||
| if (!"".equals(service.interfaceName())) { |
Member
There was a problem hiding this comment.
Use StringUtils.isNotEmpty maybe better.
| throws IllegalStateException { | ||
|
|
||
| String interfaceName; | ||
| if (!"".equals(reference.interfaceName())) { |
Member
There was a problem hiding this comment.
Use StringUtils.isNotEmpty maybe better.
| } | ||
| referenceBean.destroy(); | ||
| } | ||
| String referencedBeanName = buildReferencedBeanName(reference, injectedType); |
Member
There was a problem hiding this comment.
Multiple services referencing the same field here will cause a bug， see: d8282fe
zonghaishang
requested changes
Oct 18, 2018
|
|
||
| Class<?> referenceClass = field.getType(); | ||
| @Override | ||
| protected String buildInjectedObjectCacheKey(Reference reference, Object bean, String beanName, |
Member
There was a problem hiding this comment.
Multiple services referencing the same field here will cause a bug， see: d8282fe
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change