Skip to content

Fix timeout filter not work in async way. #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chickenlj merged 5 commits into from
Jan 24, 2019
Merged

Fix timeout filter not work in async way. #3174

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d56d8d9
Fix timeout filter not work in async way.
carryxyh Jan 9, 2019
abe5600
optimize logic.
carryxyh Jan 9, 2019
c8c1f7b
optimize binding params
carryxyh Jan 14, 2019
6d1c122
Use map to keep Invocation and startTime.
carryxyh Jan 23, 2019
a19cb2a
revert code
carryxyh Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/TimeoutFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import org.apache.dubbo.rpc.RpcException;

import java.util.Arrays;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

/**
* Log any invocation timeout, but don't stop server from running
Expand All @@ -36,21 +38,30 @@ public class TimeoutFilter implements Filter {

private static final Logger logger = LoggerFactory.getLogger(TimeoutFilter.class);

private static final Map<Invocation, Long> START_TIME_KEEPER = new ConcurrentHashMap<>();

@Override
public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcException {
long start = System.currentTimeMillis();
Comment thread
chickenlj marked this conversation as resolved.
Result result = invoker.invoke(invocation);
long elapsed = System.currentTimeMillis() - start;
if (invoker.getUrl() != null
&& elapsed > invoker.getUrl().getMethodParameter(invocation.getMethodName(),
"timeout", Integer.MAX_VALUE)) {
if (logger.isWarnEnabled()) {
logger.warn("invoke time out. method: " + invocation.getMethodName()
+ " arguments: " + Arrays.toString(invocation.getArguments()) + " , url is "
+ invoker.getUrl() + ", invoke elapsed " + elapsed + " ms.");
START_TIME_KEEPER.put(invocation, start);
return invoker.invoke(invocation);
}

@Override
public Result onResponse(Result result, Invoker<?> invoker, Invocation invocation) {
Long startTime = START_TIME_KEEPER.remove(invocation);
if (startTime != null) {
long elapsed = System.currentTimeMillis() - startTime;
if (invoker.getUrl() != null
&& elapsed > invoker.getUrl().getMethodParameter(invocation.getMethodName(),
"timeout", Integer.MAX_VALUE)) {
if (logger.isWarnEnabled()) {
logger.warn("invoke time out. method: " + invocation.getMethodName()
+ " arguments: " + Arrays.toString(invocation.getArguments()) + " , url is "
+ invoker.getUrl() + ", invoke elapsed " + elapsed + " ms.");
}
}
}
return result;
}

}
⚡